Update build-linux-clang10-mini-tsan #13220
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@archang19 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found this mismatch between the CI job title and the actual command ran incidentally while trying to work on #13213.
build-linux-clang10-mini-tsanwas added in #7122 withclang-10.In #10496 it was changed to use
clang-13but the name was not also updated. I do not know what the author's intent was, but given thatbuild-linux-clang10-mini-tsanis right next tobuild-linux-clang10-ubsanandbuild-linux-clang10-asan, I think it is more likely we originally intended to useclang-10.Test Plan
I think we need to wait for the next set of CI checks after this PR is merged, since I don't see my changes incorporated into this PR's
build-linux-clang10-mini-tsancheck.