Skip to content

Commit

Permalink
Fix for missing paths in simple suffix evaluation
Browse files Browse the repository at this point in the history
Summary:
# Bug Description
Watchman would return with missing path components
S468253

# This Diff
Adds the relative root into the path evaluation

# Technical Details
Previously without this change, the contents of the EdenFileResult would be missing the relative root component, causing following path evaluators to remove the same number of paths from the head of the desired path

Reviewed By: ezzak

Differential Revision: D65901018

fbshipit-source-id: b47700a3802a23f59af2b7da7f172f8e0caf631b
  • Loading branch information
Chris Dinh authored and facebook-github-bot committed Nov 13, 2024
1 parent 37830b2 commit a6a75aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion watchman/watcher/eden.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ class EdenView final : public QueryableView {
auto file = make_unique<EdenFileResult>(
rootPath_,
thriftChannel_,
w_string::pathCat({mountPoint_, item.name}),
w_string::pathCat({mountPoint_, relative_root, item.name}),
/*ticks=*/nullptr,
/*isNew=*/false,
item.dtype);
Expand Down

0 comments on commit a6a75aa

Please sign in to comment.