Skip to content

Commit

Permalink
Workaround build failure for range-v3 example code
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#1051

In `range-v3`, the calendar example app fails to build. This was not detected when building range-v3 itself because the calendar app is only added as a buildable executable when `boost` is available ([code](https://github.com/ericniebler/range-v3/blob/master/example/CMakeLists.txt#L32)), but `boost` is not marked as a required dependency of `range-v3` in the manifest ([code](https://www.internalfb.com/code/fbsource/fbcode/opensource/fbcode_builder/manifests/range-v3)).

During FBOSS OSS builds however, `boost` is pulled in as an indirect dependency, so the build will fail: P1677307273

This change omits building the example code.

Reviewed By: harshitgulati18

Differential Revision: D65774962

fbshipit-source-id: 7f9f1238f08d6785981a53ae669989b95c63fa43
  • Loading branch information
paulcruz74 authored and facebook-github-bot committed Nov 12, 2024
1 parent 0413e06 commit 5be00df
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build/fbcode_builder/manifests/range-v3
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ sha256 = 376376615dbba43d3bef75aa590931431ecb49eb36d07bb726a19f680c75e20c
[build]
builder = cmake
subdir = range-v3-0.11.0

[cmake.defines]
RANGE_V3_EXAMPLES=OFF

0 comments on commit 5be00df

Please sign in to comment.