Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing tmpdir when running in slurm + not depending anymore on torchaudio for writing audio files. #306

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

adefossez
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2023
@adefossez adefossez requested a review from JadeCopet October 9, 2023 13:36
@adefossez adefossez changed the title changing tmpdir when running in slurm changing tmpdir when running in slurm + not depending anymore on torchaudio for writing audio files. Oct 9, 2023
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex!

@adefossez adefossez merged commit 5d8752d into main Oct 12, 2023
3 checks passed
Dinglet pushed a commit to Dinglet/audiocraft that referenced this pull request Jul 30, 2024
…haudio for writing audio files. (facebookresearch#306)

* changing tmpdir when runnign in slurm

* fixing typing in dadam

* limiting dependency on torchaudio for writing files

* not using torchaudio for reading anymore

* trying desperatly to get those unit tests to pass

* plop

* fixing tests once more

* linter

* plop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants