Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet xformers 0.0.22 compatibility fix #394

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

lonzi
Copy link
Contributor

@lonzi lonzi commented Jan 16, 2024

MAGNeT - Fix for xformers 0.0.22 compatibility, thanks to @nateraw catch.

  • Inference was already tested
  • Testing now training as well

In addition, the following smaller fixes are also contained in this PR:

  • MAGNeT notebook - change to stride1 span arrangement by default which works better than the nonoverlap reported in the paper
  • MAGNeT doc fix of a typo
  • MAGNeT music training grid typo fix

@lonzi lonzi requested review from JadeCopet and felixkreuk January 16, 2024 11:00
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2024
@nateraw
Copy link

nateraw commented Jan 16, 2024

Can confirm this resolves #390 :) thanks!!

@lonzi lonzi mentioned this pull request Jan 17, 2024
@lonzi
Copy link
Contributor Author

lonzi commented Jan 17, 2024

Validated also that training functions correctly. Generation results after 25 epochs sound totally sane. Ready for merge.

Copy link
Contributor

@felixkreuk felixkreuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lonzi lonzi merged commit 2a5c5e9 into main Jan 17, 2024
3 checks passed
Dinglet pushed a commit to Dinglet/audiocraft that referenced this pull request Jul 30, 2024
MAGNeT - Fix for xformers 0.0.22 compatibility, thanks to @nateraw catch.

In addition, the following smaller fixes are also contained in this PR:
* MAGNeT notebook - change to stride1 span arrangement by default.
* MAGNeT doc fix of a typo.
* MAGNeT music training grid typo fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants