-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aspect ratio model #5048
Closed
wenliangzhao2018
wants to merge
0
commits into
facebookresearch:main
from
wenliangzhao2018:export-D47682434
Closed
Add aspect ratio model #5048
wenliangzhao2018
wants to merge
0
commits into
facebookresearch:main
from
wenliangzhao2018:export-D47682434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Aug 2, 2023
This pull request was exported from Phabricator. Differential Revision: D47682434 |
wenliangzhao2018
pushed a commit
to wenliangzhao2018/d2go
that referenced
this pull request
Aug 2, 2023
Summary: X-link: facebookresearch/detectron2#5048 Unet support different aspect ratio by natural. For training we need to make change to group images with similar aspect ratio into the same batch and do padding/cropping. For inference, we need to change start_code dimension accordingly. Here is a result showing 1:1 and 16:9 inference are similar. It supports the mixed training decision. N4024922 Differential Revision: D47682434 fbshipit-source-id: f28823dc04adfff4a88f3991305c437703b92970
wenliangzhao2018
pushed a commit
to wenliangzhao2018/d2go
that referenced
this pull request
Aug 2, 2023
Summary: Pull Request resolved: facebookresearch#604 X-link: facebookresearch/detectron2#5048 Unet support different aspect ratio by natural. For training we need to make change to group images with similar aspect ratio into the same batch and do padding/cropping. For inference, we need to change start_code dimension accordingly. Here is a result showing 1:1 and 16:9 inference are similar. It supports the mixed training decision. N4024922 Differential Revision: D47682434 fbshipit-source-id: ee2554fd7248f628cf41ce29dedcf4d542d12baa
wenliangzhao2018
pushed a commit
to wenliangzhao2018/detectron2
that referenced
this pull request
Aug 2, 2023
Summary: X-link: facebookresearch/d2go#604 Pull Request resolved: facebookresearch#5048 Unet support different aspect ratio by natural. For training we need to make change to group images with similar aspect ratio into the same batch and do padding/cropping. For inference, we need to change start_code dimension accordingly. Here is a result showing 1:1 and 16:9 inference are similar. It supports the mixed training decision. N4024922 Differential Revision: D47682434 fbshipit-source-id: bc9578b7167c475d48b385ce472b7aa8baeae7c6
wenliangzhao2018
force-pushed
the
export-D47682434
branch
from
August 2, 2023 22:29
584f24a
to
19bdaca
Compare
This pull request was exported from Phabricator. Differential Revision: D47682434 |
wenliangzhao2018
pushed a commit
to wenliangzhao2018/d2go
that referenced
this pull request
Aug 2, 2023
Summary: Pull Request resolved: facebookresearch#604 X-link: facebookresearch/detectron2#5048 Unet support different aspect ratio by natural. For training we need to make change to group images with similar aspect ratio into the same batch and do padding/cropping. For inference, we need to change start_code dimension accordingly. Here is a result showing 1:1 and 16:9 inference are similar. It supports the mixed training decision. N4024922 Differential Revision: D47682434 fbshipit-source-id: 2478a64775717cb178e525ac127232a24f1d40a3
wenliangzhao2018
force-pushed
the
export-D47682434
branch
from
August 3, 2023 00:05
19bdaca
to
57bdb21
Compare
This pull request was exported from Phabricator. Differential Revision: D47682434 |
wenliangzhao2018
pushed a commit
to wenliangzhao2018/d2go
that referenced
this pull request
Aug 3, 2023
Summary: Pull Request resolved: facebookresearch#604 X-link: facebookresearch/detectron2#5048 Unet support different aspect ratio by natural. For training we need to make change to group images with similar aspect ratio into the same batch and do padding/cropping. For inference, we need to change start_code dimension accordingly. Here is a result showing 1:1 and 16:9 inference are similar. It supports the mixed training decision. N4024922 Differential Revision: D47682434 fbshipit-source-id: f79591180098fd67d4e443976410f63f9e39a432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Unet support different aspect ratio by natural. For training we need to make change to group images with similar aspect ratio into the same batch and do padding/cropping. For inference, we need to change start_code dimension accordingly.
Here is a result showing 1:1 and 16:9 inference are similar. It supports the mixed training decision. N4024922
Differential Revision: D47682434