Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logging period configurable via TRAINER.LOG_PERIOD #5394

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make logging period configurable via TRAINER.LOG_PERIOD #5394

wants to merge 4 commits into from

Conversation

VishalJ99
Copy link

@VishalJ99 VishalJ99 commented Nov 16, 2024 •
edited
Loading

What does this PR do?

Makes logging period configurable via TRAINER.LOG_PERIOD config value.

Previously, the logging period was hardcoded. Making this configurable allows users to:

  • Debug training by viewing metrics at every iteration (period=1).
  • Fine-tune logging granularity based on their needs.

Changes Made

  • Added TRAINER.LOG_PERIOD config option in detectron2/config/defaults.py with default value of 20 to maintain backward compatibility.
  • Added unit test to verify the config is respected.

Testing

Added unit test test_log_period that verifies:

  • Custom log period value is properly passed to the PeriodicWriter hook.

Make logging period configurable via TRAINER.LOG_PERIOD
2be7fd2 
Previously, the logging period was hardcoded. Making this configurable via
TRAINER.LOG_PERIOD allows users to:
- Debug training by viewing metrics at every iteration (period=1)
- Reduce logging frequency for long training runs
- Fine-tune logging granularity based on their needs

The default value of 20 maintains backward compatibility while providing
flexibility through configuration.

Changes:
- Added TRAINER.LOG_PERIOD config option
- Added unit test to verify configuration works
@facebook-github-bot
Copy link
Contributor

Hi @VishalJ99!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@VishalJ99
Update test_trainer.py
5d59525 
Remove unrelated inline comment.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VishalJ99 @facebook-github-bot