Isolate urllib.request.urlretrieve for later replacement. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch simply refactors to isolate
urllib.request.urlretrievein a separate function to simplify later code review.This is intended to be a starting point for a conversation about replacing
urllib.request.urlretrievewithrequests.get.The newer interface offers quality-of-life features, in particular, using the environment variable REQUESTS_CA_BUNDLE to allow downloading through a proxy.
The legacy
urllib.request.urlretrieveinterface doesn't even respect SSL_CERT_FILE, making it impossible to use fvcore without manually changing the internals.Since pip itself uses
requeststhese days, introducing a dependency onrequestsis probably not worth worrying about.