More idiomatic param update #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jun 6, 2023
Summary: The out of place .data manipulation is slower/more memory, and doesnt work with cudagraphs. Upstream pr link: facebookresearch/moco#141 Pull Request resolved: #1693 Reviewed By: xuzhao9 Differential Revision: D46453742 Pulled By: eellison fbshipit-source-id: 2072103ba9edd29444ff8cc16b6dc393c4f7a95d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter updates are typically done in-place, because it is more memory efficient, faster, and works with cudagraphs