Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expanding variables and home dir in path_tempfile #175

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

gerardroche
Copy link

Support expand env vars and home user in path_tempfile.

This allows you specify paths with ~ and variables like $HOME:

"path_tempfile": "~/.cache/markdownpreview"
  • refactor: get temp preview path

This allows you specify paths with `~` and variables like `$HOME`:

    "path_tempfile": "~/.cache/markdownpreview"
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: markdown-preview Main code. C: settings Sublime settins files. C: source Related to source code. labels Dec 17, 2023
@facelessuser
Copy link
Owner

Thanks for the PR. This seems like a reasonable addition.

@facelessuser
Copy link
Owner

Documentation failures can be ignored. I need to address the current issues in a separate commit.

@facelessuser
Copy link
Owner

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Dec 29, 2023
@facelessuser facelessuser merged commit e5508dd into facelessuser:master Dec 29, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: docs Related to documentation. C: markdown-preview Main code. C: settings Sublime settins files. C: source Related to source code. S: approved The pull request is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants