sameids: fix trailing identifier highlighting #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix same id highlighting of identifiers that are at the very end of a line. Fixes fatih#3605
Fix jumping to a definition so that it uses the actual definition line to calculate the position of the definition when the definition is not in the current buffer.
use getbufoneline when it's available to get a line instead of getting all the lines of a buffer and selecting only the line of interest.
bhcleek
force-pushed
the
sameids/off-by-one
branch
from
58eda61 to
c5b51a0
Compare
bhcleek
added a commit
that referenced
this pull request
Dec 5, 2023
|
Good job, yet again… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix same id highlighting of identifiers that are at the very end of a line.
Fixes #3605