fix fatih/vim-go/issues/3690: set noshellslash only on win32
#3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In neovim nightly, neovim/neovim/pull/28400 was merged: > The value of shellslash should show true now outside of Windows. > set shellslash should work on POSIX while set noshellslash will fail This PR for vim-go wraps `set noshellslash` between a `if has("win32")` conditional to ensure that the functions no longer error in POSIX environments. Signed-off-by: Stanley Chan <pocketgamer5000@gmail.com>
|
Thank you for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In neovim nightly, neovim/neovim/pull/28400 was merged:
This PR for vim-go wraps
set noshellslashbetween aif has("win32")conditional to ensure that the functions no longer error in POSIX environments.