Improve error message for removing a column

fatkodima · Oct 19, 2024 · 630c78f · 630c78f
1 parent f5e0423
commit 630c78f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/online_migrations/error_messages.rb b/lib/online_migrations/error_messages.rb
@@ -279,8 +279,8 @@ def change
 
       remove_column:
 "<% if !small_table && indexes.any? %>
-Removing a column will automatically remove all of the indexes that involved the removed column.
-But the indexes would be removed non-concurrently, so you need to safely remove the indexes first:
+Removing a column will automatically remove all the indexes that include this column.
+Indexes will be removed non-concurrently, so you need to safely remove them first:
 
 class <%= migration_name %>RemoveIndexes < <%= migration_parent %>
   disable_ddl_transaction!

diff --git a/test/command_checker/removing_columns_test.rb b/test/command_checker/removing_columns_test.rb
@@ -77,8 +77,8 @@ def change
 
     def test_remove_column_with_index
       assert_unsafe RemoveColumnWithIndex, <<~MSG
-        Removing a column will automatically remove all of the indexes that involved the removed column.
-        But the indexes would be removed non-concurrently, so you need to safely remove the indexes first:
+        Removing a column will automatically remove all the indexes that include this column.
+        Indexes will be removed non-concurrently, so you need to safely remove them first:
 
         class CommandChecker::RemovingColumnsTest::RemoveColumnWithIndexRemoveIndexes < #{migration_parent}
           disable_ddl_transaction!