Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list items in README.md [skip ci] #43

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix list items in README.md [skip ci] #43

merged 1 commit into from
Nov 13, 2023

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented Nov 13, 2023

This change aims to align separated (unexpected?) list items in README.md as HTML.

For an example of "Removing a column", the multiple lists (<ol>) are rendered currenty:

<ol>
  <li>Ignore the column:</li>
</ol>
...
<ol start="2">
  <li>Deploy:</li>
  <li>Wrap column removing in ...</li>
</ol>
...
<ol start="4">
  <li>Remove column ignoring from ...</li>
  <li>Deploy</li>
</ol>

But, one list should be rendered here. This change fixes them:

<ol>
  <li>Ignore the column:</li>
  <li>Deploy:</li>
  <li>Wrap column removing in ...</li>
  <li>Remove column ignoring from ...</li>
  <li>Deploy</li>
</ol>

Please feel free to close this PR if the current rendered result is expected.


Note: Hiding whitespaces in the diff view would help us review this change.

This change aims to align separated (unexpected?) list items in `README.md` as HTML.

For an example of "Removing a column", the multiple lists (`<ol>`) are rendered currenty:

```html
<ol>
  <li>Ignore the column:</li>
</ol>
...
<ol start="2">
  <li>Deploy:</li>
  <li>Wrap column removing in ...</li>
</ol>
...
<ol start="4">
  <li>Remove column ignoring from ...</li>
  <li>Deploy</li>
</ol>
```

But, one list should be rendered here. This change fixes them:

```html
<ol>
  <li>Ignore the column:</li>
  <li>Deploy:</li>
  <li>Wrap column removing in ...</li>
  <li>Remove column ignoring from ...</li>
  <li>Deploy</li>
</ol>
```
@fatkodima fatkodima changed the title Fix list items in README.md Fix list items in README.md [skip ci] Nov 13, 2023
@fatkodima fatkodima merged commit b48b984 into fatkodima:master Nov 13, 2023
11 checks passed
@ybiquitous ybiquitous deleted the fix-list-items-in-readme branch November 13, 2023 10:30
@ybiquitous
Copy link
Contributor Author

Wow, thanks for the quick merge! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants