Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuring docs #51

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

camallen
Copy link
Contributor

Closes #50

This PR adds clarifying wording to docs/configuring.md. Specifically about how

  • the lock retrier works when the migration runs without a transaction, e.g. using disable_ddl_transaction!
  • the default behaviour of NullLockRetrier specifies a lock_timeout of 0 and thus disables the timeout

Happy to iterate on this wording where you think appropriate.

docs/configuring.md Outdated Show resolved Hide resolved
docs/configuring.md Outdated Show resolved Hide resolved
@fatkodima fatkodima merged commit 2040b86 into fatkodima:master Mar 15, 2024
5 checks passed
@camallen camallen deleted the update-configuring-docs branch March 16, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarity on lock retry behaviour inside and outside transactions
2 participants