Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue no 3: SideNav left to right #14

Closed
wants to merge 1 commit into from

Conversation

afraz-afaq
Copy link

Fixed the issue #3 Re-position Menu & Menu button on right side.

@nawazishali
Copy link
Contributor

Hey @afraz-afaq Thanks for making a PR, But this can't be merged due to following reasons.

  1. Branch name is not according to the convention we are using, i.e fix/menu-issue
  2. Style properties must be avoided as long as possible.
  3. When the logo is menu icon is floated left you Logo must move a to the left corner.

Here are some possible solutions.

  1. There are .right & .left classes already available in the library. Try using them.
  2. Change the style for brand-logo img there is a margin-left of 35px on the logo image which is making it look bad on mobile screen.
  3. Make another PR from proper branch name so that we can merge it.

Ask more questions if you need help.

@afraz-afaq
Copy link
Author

@nawazishali thanks for your response I have used .right class but for brand-logo img to remove margin-left i must use style properties?

@nawazishali
Copy link
Contributor

@afraz-afaq You can either add a class of your own or directly target img styles in css. If you have confusion with that part you can always ask for help.

@nawazishali
Copy link
Contributor

@afraz-afaq If you are still working on the issue, Than please get it assigned to yourself by commented at the actual issue itself. Also join our organization here

@afraz-afaq afraz-afaq closed this Mar 24, 2018
@afraz-afaq afraz-afaq deleted the fix_menu_issue branch March 24, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants