[WIP Do Not Merge] N/A cannot be built into URL for filtering Datatables #5347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Don't link contribution amount when Employer is
N/A
since a value with aslash ("/")
cannot be passes to the URL because it is a reserved char for a URLWhether we put
N/A
in a link to filtered datatable or a user putsN/A
in the employer field on a datatable, the API call will always turn it intoN%2FA
. So while the filter tags and the checkbox select showsN/A
verbatim, it is always callingN%2FA
.(Which does not return only contributors who submitted N/A, verbatim) See screenshots in issue commentOne mitigating factor to any concerns about not linking the amount on the profile page table is the existence of the "Filter this data" button directly above the table, allowing users to click through to the datatable.
Resolves N/A for schedule A datatable not filtering correctly from canonical page #5220
Required reviewers
one frontend
Impacted areas of the application
committee-single.js
How to test
Employer
, tab If the employer isN/A
, the contribution amount should not be linked