Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP Do Not Merge] N/A cannot be built into URL for filtering Datatables #5347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Jul 25, 2022

Summary (required)

  • Don't link contribution amount when Employer is N/A since a value with a slash ("/") cannot be passes to the URL because it is a reserved char for a URL

  • Whether we put N/A in a link to filtered datatable or a user puts N/A in the employer field on a datatable, the API call will always turn it into N%2FA. So while the filter tags and the checkbox select shows N/A verbatim, it is always calling N%2FA.(Which does not return only contributors who submitted N/A, verbatim) See screenshots in issue comment

  • One mitigating factor to any concerns about not linking the amount on the profile page table is the existence of the "Filter this data" button directly above the table, allowing users to click through to the datatable.

  • Resolves N/A for schedule A datatable not filtering correctly from canonical page #5220

Required reviewers

one frontend

Impacted areas of the application

committee-single.js

How to test

@johnnyporkchops johnnyporkchops changed the title N/A cannot be built into URL for filtering Datatables [WIP Do Not Merge] N/A cannot be built into URL for filtering Datatables Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

N/A for schedule A datatable not filtering correctly from canonical page
2 participants