Scan for JS code also in CSS comments #19
Merged
+58
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Cleaner()` now scans for hidden JavaScript code embedded within CSS comments. In certain contexts, such as within `<svg>` or `<math>` tags, `<style>` tags may lose their intended function, allowing comments like `/* foo */` to potentially be executed by the browser.
|
The current solution is too strict and I have to rework it a bit. |
frenzymadness
force-pushed
the
fix_js_css_comment
branch
from
02de1e4
to
60c0cb2
Compare
|
@hrnciar PTAL |
|
The security researcher who reported this vulnerability confirmed that the fix is good and covers many payloads from the same category of attacks. |
|
I also like your solution. Thank you. +1 |
hroncok
reviewed
Nov 14, 2024
| """ | ||
| for match in self._find_comments(style): | ||
| comment = match.group(0) | ||
| print("f", comment) |
There was a problem hiding this comment.
This seems like a leftover debug print.
EDIT: #20
hroncok
reviewed
Nov 14, 2024
| print("f", comment) | ||
| if _has_javascript_scheme(comment) or _looks_like_tag_content(comment): | ||
| style = style.replace(comment, "/* deleted */") | ||
| print("f", style) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cleaner()now scans for hidden JavaScript code embeddedwithin CSS comments. In certain contexts, such as within
<svg>or
<math>tags,<style>tags may lose their intended function,allowing comments like
/* foo */to potentially be executed bythe browser.