FIX: Allow multiple inlined image data links in html clean #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a lazy quantifier in the regex
_find_image_dataurls
to match as few characters as possible,to make it stop at the first occurence of
;base64,
e.g.
This allows to have multiple image data links on the same line, which happens for instance in inline styles.
Without this change,
_has_javascript_scheme
returnsTrue
because the count of safe image urls is lower than the number of possible malicious scheme.Then, the whole style is dropped as considered malicious.