Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mason): define BrickIgnore class #1227

Closed

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Jan 23, 2024

Status

READY FOR REVIEW

Description

This is a part of #781, yet to be followed by another Pull Request to adjust the bundling logic.

Changes:

  • Adds the glob dependency
  • Adds BrickIgnore class
  • Defines BrickIgnore.isIgnored and BrickIgnore.fromFile

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

wolfenrain
wolfenrain previously approved these changes Jan 29, 2024
@felangel
Copy link
Owner

felangel commented Feb 8, 2024

I'll have a closer look tomorrow, apologies for the delayed review!

@felangel
Copy link
Owner

felangel commented Mar 7, 2024

As discussed offline @alestiago would you be okay with pushing additional commits for the remainder of the changes so that everything can be reviewed as a whole (I know the diff will be larger) but it would be helpful for me to review everything together to make sure it all integrates well. Sorry for the delay on this and looking forward to getting it merged 🎉

@felangel
Copy link
Owner

Closing this for now since it's been a while but happy to take a look whenever you have time to pick it back up!

@felangel felangel closed this Oct 31, 2024
@alestiago
Copy link
Collaborator Author

Sounds good! I haven't had bandwidth to tackle this, I'll let you know if I have any at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants