Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mocktail_image_network): add customizable imageBytes #214

Merged
merged 8 commits into from
Jan 19, 2024
Merged

feat(mocktail_image_network): add customizable imageBytes #214

merged 8 commits into from
Jan 19, 2024

Conversation

ABausG
Copy link
Contributor

@ABausG ABausG commented Oct 17, 2023

Status

READY

Breaking Changes

NO

Description

This adds the ability to mock a custom image when using mockNetworkImages. This can be used for the following:

  • Provide better visuals when doing golden tests as this allows showing an actual image inside the golden tests
  • Mock SVG Images which can otherwise lead to errors in tests when using network based svg images

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@ABausG ABausG requested a review from felangel as a code owner October 17, 2023 12:17
@felangel felangel added the enhancement New feature or request label Jan 19, 2024
@felangel felangel changed the title feat(mocktail_image_network): add ability to return custom image data feat(mocktail_image_network): add customizable imageBytes Jan 19, 2024
felangel
felangel approved these changes Jan 19, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution! ✅

@felangel felangel merged commit 53e8132 into felangel:main Jan 19, 2024
3 checks passed
@ABausG ABausG deleted the custom-image branch January 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@ABausG ABausG

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABausG @felangel