Bring in missing python (system dependency) #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraravam
force-pushed
the
sqlite-and-python
branch
7 times, most recently
from
a2aa57e
to
e92e8fa
Compare
(needed by node-gyp to compile native modules) Introduce node-pre-gyp as a dependency
vraravam
force-pushed
the
sqlite-and-python
branch
from
c6e1949
to
6ebbda5
Compare
Alphrag
reviewed
Mar 28, 2024
| @@ -141,6 +143,7 @@ | |||
| "@electron/notarize": "1.2.3", | |||
| "@formatjs/cli": "6.2.7", | |||
| "@jest/types": "29.6.3", | |||
| "@mapbox/node-pre-gyp": "1.0.11", | |||
There was a problem hiding this comment.
The sqlite3 module has moved away from using node-pre-gyp and is using prebuild-install instead (cf TryGhost/node-sqlite3#1735), so I do not think this dependency is needed nowadays.
6 tasks
vraravam
added a commit
that referenced
this pull request
Mar 31, 2024
Since its causing all builds to fail This reverts commit 53c72ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Use the upgrade of sqlite as a litmus test to bring in missing python (system dependency)
Motivation and Context
For most native dependencies, if a pre-built binary is not available, npm will then try to build from source, which includes using python and node-gyp to compile. The intention of this PR is to resurrect python if needed to be able to support those modules that need native compilation on different OSes. I am trying to see if sqlite3 (at the current moment, no pre-built binaries are present for the latest version) can be used as a litmus test for the above build setup on both local and CI.
Screenshots
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes