Added new recipe - Hacker News (YCombinator) #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmxcdev
reviewed
Jan 5, 2024
| { | ||
| "id": "hackernews", | ||
| "name": "Hacker News", | ||
| "version": "1.3.0", |
There was a problem hiding this comment.
Every new recipe needs to start with version 1.0.0
Comment on lines
+9
to
+10
| // get unread messages | ||
| const count = document.querySelectorAll('.guilds-wrapper .badge').length; |
There was a problem hiding this comment.
Are there even any notifications on hackernews?
Comment on lines
+18
to
+19
| // Hide download message | ||
| Ferdium.injectCSS(_path.default.join(__dirname, 'service.css')); |
There was a problem hiding this comment.
The comment here seems out of place, probably needs to be removed.
recipes/hackernews/icon.svg
Outdated
There was a problem hiding this comment.
The icon on the website is orange square with a "Y" in the middle. The icon you have provided here is only an orange square without the "Y" inside.
SpecialAro
requested changes
Jan 7, 2024
There was a problem hiding this comment.
Please fix the comments by @mcmxcdev so we can move to merge. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Added new recipe of hackernews from ycombinator