Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several recipes #519

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Add several recipes #519

merged 1 commit into from
Mar 18, 2024

Conversation

SpecialAro
Copy link
Member

@SpecialAro SpecialAro commented Mar 17, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

This PR adds 16 new recipes (fixing several recipe requests on the Ferdium-App issue board).

The added recipes are as follows:

@SpecialAro SpecialAro requested a review from a team March 17, 2024 02:34
@SpecialAro SpecialAro self-assigned this Mar 17, 2024
@SpecialAro
Copy link
Member Author

SpecialAro commented Mar 17, 2024

Build failing possibly because I force-pushed a commit (it shouldn't fail though...) - it is complaining about not version bump on alibaba-chat (which is impossible - the version bump action runs successfuly).

Let's wait a few for a new runner to re-trigger the build again to see if it fixes (probably has to do with cache on the runner side).

In the meantime, if anyone cares to try and package locally, you would see that everything is fine:
image

Copy link
Contributor

@mcmxcdev mcmxcdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for another one of these recipe implementation sweeps!

The only thing that concerns me: we will close all these issues but most of these recipes don't have any notification functionality, so they don't do anything useful?

@SpecialAro
Copy link
Member Author

Wow, thanks for another one of these recipe implementation sweeps!

You're welcome 😁

The only thing that concerns me: we will close all these issues but most of these recipes don't have any notification functionality, so they don't do anything useful?

That is true, yes... I only implemented notification sounds to those requests where users explicitly said it was a feature.. nevertheless I think that we can tackle those issues as they come or even gradually see what recipes have notifications and implement it pro-actively.

@mcmxcdev
Copy link
Contributor

That is true, yes... I only implemented notification sounds to those requests where users explicitly said it was a feature.. nevertheless I think that we can tackle those issues as they come or even gradually see what recipes have notifications and implement it pro-actively.

We can also rely on users adding in functionality for recipes as we go.

@SpecialAro SpecialAro merged commit 0069503 into ferdium:main Mar 18, 2024
2 checks passed
@SpecialAro SpecialAro deleted the several-recipes branch March 18, 2024 12:36
@NocturnalNick
Copy link

@SpecialAro
Is login to Notion Calendar working? I can't figure out a way to log in, am I missing something

@SpecialAro
Copy link
Member Author

@NocturnalNick it seems it is not working properly (login with Google is always a PITA). I'll try to find a workaround

@NocturnalNick
Copy link

NocturnalNick commented Apr 8, 2024

@NocturnalNick it seems it is not working properly (login with Google is always a PITA). I'll try to find a workaround
@SpecialAro
A million thanks for trying and even more if successful! Just wish I could auth with the authenticator app and a QR code or something.

@SpecialAro
Copy link
Member Author

@NocturnalNick I just pushed a PR to fix this. It should be fixed in the latest nightly 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants