Merge pull request #14124 from cheesegrits/3.x-summary-test

Use assertEqualsCanonicalized() for summary testing
filamentphp · Sep 3, 2024 · ea87f9a · ea87f9a
2 parents 66a53f3 + b9a35cd
commit ea87f9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/tables/docs/12-testing.md b/packages/tables/docs/12-testing.md
@@ -638,6 +638,8 @@ it('can average values in a column', function () {
 
 The first argument is the column name, the second is the summarizer ID, and the third is the expected value.
 
+Note that the expected and actual values are normalized, such that `123.12` is considered the same as `"123.12"`, and `['Fred', 'Jim']` is the same as `['Jim', 'Fred']`.
+
 You may set a summarizer ID by passing it to the `make()` method:
 
 ```php

diff --git a/packages/tables/src/Testing/TestsSummaries.php b/packages/tables/src/Testing/TestsSummaries.php
@@ -39,7 +39,7 @@ public function assertTableColumnSummarySet(): Closure
 
             $livewireClass = $this->instance()::class;
 
-            Assert::assertSame(
+            Assert::assertEqualsCanonicalizing(
                 $state,
                 $actualState,
                 message: "Failed asserting that summarizer [$summarizerId], for column [{$columnName}], on the [{$livewireClass}] component, is set.",
@@ -73,7 +73,7 @@ public function assertTableColumnSummaryNotSet(): Closure
 
             $livewireClass = $this->instance()::class;
 
-            Assert::assertNotSame(
+            Assert::assertNotEqualsCanonicalizing(
                 $state,
                 $actualState,
                 message: "Failed asserting that summarizer [$summarizerId], for column [{$columnName}], on the [{$livewireClass}] component, is not set.",