Improve folder enumeration speed

[gave92]

Resolved / Related Issues
For #4180

Details of Changes

• Removes caching feature
• Perf tweaks to folder loading code: removed calls to StorageFolder methods when not strictly needed
• Fixes an issue for which icons are not loaded when browsing mtp devices

Warning
These changes creates issues with the "current" details view, I find the app crashing every 5 folders.
This only happens with the WCT datagrid layout mode, the "new" details view works good.
This actually looks like a bug with WCT and has been known for a while (#4304) but these changes seem to make the crash more common.
Depending on how we plan to ship the next version (new or old details view) it may make sense to wait before doing this change, but I'd love to get some feedbacks on how well this PR work for you.

Validation
How did you test these changes?

• Built and ran the app
• Tested loading folders from disk, network, mtp (phone)

[yaira2]

Depending on how we plan to ship the next version (new or old details view) it may make sense to wait before doing this change, but I'd love to get some feedbacks on how well this PR work for you.

@gave92 The new details layout will replace the old one in v2.

[lukeblevins]

This looks like a good improvement as long as we remove the old details layout before v2

[yaira2]

@gave92 It seems like the status bar isn't updating anymore. Another issue is that everything seems very choppy when loading large directories.

[gave92]

@yaichenbaum is status bar working in main for you?

[yaira2]

@yaichenbaum is status bar working in main for you?

It looks like it's an issue in main as well.

[gave92]

Another issue is that everything seems very choppy when loading large directories.

@yaichenbaum is this still an issue? If so could you clarify? I would not expect it to be "more choppy" than the current.

[yaira2]

Another issue is that everything seems very choppy when loading large directories.

@yaichenbaum is this still an issue? If so could you clarify? I would not expect it to be "more choppy" than the current.

It appears to be working better now, I noticed a different issue where the app seems to scroll down after loading the system 32 directory in the details layout.

[gave92]

It appears to be working better now, I noticed a different issue where the app seems to scroll down after loading the system 32 directory in the details layout.

Could you get me a screen recording of this? I have trouble reproducing

[yaira2]

It appears to be working better now, I noticed a different issue where the app seems to scroll down after loading the system 32 directory in the details layout.

Could you get me a screen recording of this? I have trouble reproducing

I reset Files and I can't reproduce it anymore 😂

[yaira2]

LGTM