Added a setting to enable or disable saving recent items opened

[BanCrash]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Recent items shouldn't register elements when you have it disabled #5882

Details of Changes

• Added a setting to enable or disable saving recent items opened (enabled by default)
  Disabling this setting will disable also Recent files widget, and won't let you enable it back until the setting is enabled again. Will remove recent items too.
  You can have the setting enable and not have the recent files widget enabled, because this setting will also affect the jump list (that's why I added a new setting instead just making this when you disable recent files widget).

TO DO:

• Figure out why it needs a Files restart to refresh the value of IsSavingRecentItemsEnabled in the Widgets settings.
  Unrelated to this PR since File Tags are not getting their value refreshed on the InnerNavigationToolbar neither.

• Figure out how to refresh all home tabs opened when this changes.
  Unrelated to this PR since this also present on Recent Files, if you have several tabs with Home opened, if you disable Recent Files it will only be update on the tab where you change it, but on the others will not be refreshed. I think this should be include in Feature: Auto refresh drive widget & tags widget when changes are detected #6182 , and automatically refreshing the home page when there are widgets or drives changes. So, it's unrelated to this PR.

Validation

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)

Disable Recent Files widget and not letting you enable it back (currently it needs a restart of Files app):

[d2dyno1]

Instead adding a new setting, I guess it shouldn't register recent items when the widget is disabled.

[BanCrash]

Instead adding a new setting, I guess it shouldn't register recent items when the widget is disabled.

I did this way because of this:

You can have the setting enable and not have the recent files widget enabled, because this setting will also affect the jump list (that's why I added a new setting instead just making this when you disable recent files widget).

[BanCrash]

Instead adding a new setting, I guess it shouldn't register recent items when the widget is disabled.

I did this way because of this:

You can have the setting enable and not have the recent files widget enabled, because this setting will also affect the jump list (that's why I added a new setting instead just making this when you disable recent files widget).

Ok, but we already have Bundles for that matter. Recent items does not serve the purpose as mentioned above, it'd be bad UX.

I'm talking about this:

(Image taken from #5577 , @xezrunner comment)

If we don't save recent items this jumplist will be empty too, I don't think this overlaps with Bundles.

[yaira2]

@duke7553 brought up the idea of keeping the list in sync with the list of recent items in File Explorer, just wondering if that changes anything in regards to this PR.

[lukeblevins]

(The Recents folder leveraged by Explorer)

[BanCrash]

@duke7553 brought up the idea of keeping the list in sync with the list of recent items in File Explorer, just wondering if that changes anything in regards to this PR.

@yaichenbaum I've been thinking but I think there is nothing to change here, maybe when that is added it will modify NavigationHelper but I don't think that would require a lot of changes regarding the additions on this PR (probably just move the if condition added on this PR to the new place, but without knowing the future changes there is nothing sure).

[BanCrash]

Okay, I think that on this state is ready to review, since:

First issue: Is also present on Recent Files, if you have several tabs with Home opened, if you disable Recent Files it will only be update on the tab where you change it, but on the others will not be refreshed. I think this should be include in #6182 , and automatically refreshing the home page when there are widgets or drives changes. So, it's unrelated to this PR.

About the other issue:

@d2dyno1 InnerNavigationToolbar is not getting Tags state update neither until you restart Files, If you disable Tags they will still be showed as an option of rearrange until you restart Files:

Etiqueta de archivo = Tags

After restarting Files "Etiquetas de archivo" disappear:

So it's unrelated to this PR too.

[d2dyno1]

@BanCrash I'll try to fix the second issue in #6542

[yaira2]

@BanCrash can you move the setting to preferences?

[BanCrash]

@BanCrash can you move the setting to preferences?

Done!

[yaira2]

Code wise this looks good, but I'm concerned about the UX of this setting. Would it be better to just add recent items to the same list File Explorer uses so you can control everything in the same place?

[d2dyno1]

About the other issue:

@d2dyno1 InnerNavigationToolbar is not getting Tags state update neither until you restart Files, If you disable Tags they will still be showed as an option of rearrange until you restart Files

It's been fixed in 641e1d9 (#6542)

[BanCrash]

Code wise this looks good, but I'm concerned about the UX of this setting. Would it be better to just add recent items to the same list File Explorer uses so you can control everything in the same place?

@yaichenbaum sorry about the delay to answer, I was waiting to made some test and research but since I have exams I doesn't have much time these weeks. When I made that research and tests I will answer your question with the results that I'll get.

[Cheese-Echidna]

Please merge this I would really like this feature! :)