Fix lint and test

firebase · Nov 19, 2024 · c04763b · c04763b
1 parent 084440c
commit c04763b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/auth/token_generator.go b/auth/token_generator.go
@@ -172,12 +172,12 @@ type iamSigner struct {
 
 func newIAMSigner(ctx context.Context, config *internal.AuthConfig) (*iamSigner, error) {
 	hc, _, err := internal.NewHTTPClient(ctx, config.Opts...)
-	hc.Opts = []internal.HTTPOption{
-		internal.WithHeader("x-goog-api-client", internal.GetMetricsHeader(config.Version)),
-	}
 	if err != nil {
 		return nil, err
 	}
+	hc.Opts = []internal.HTTPOption{
+		internal.WithHeader("x-goog-api-client", internal.GetMetricsHeader(config.Version)),
+	}
 
 	return &iamSigner{
 		mutex:        &sync.Mutex{},

diff --git a/iid/iid.go b/iid/iid.go
@@ -116,12 +116,12 @@ func NewClient(ctx context.Context, c *internal.InstanceIDConfig) (*Client, erro
 	}
 
 	hc, _, err := internal.NewHTTPClient(ctx, c.Opts...)
-	hc.Opts = []internal.HTTPOption{
-		internal.WithHeader("x-goog-api-client", internal.GetMetricsHeader(c.Version)),
-	}
 	if err != nil {
 		return nil, err
 	}
+	hc.Opts = []internal.HTTPOption{
+		internal.WithHeader("x-goog-api-client", internal.GetMetricsHeader(c.Version)),
+	}
 
 	hc.CreateErrFn = createError
 	return &Client{

diff --git a/internal/http_client.go b/internal/http_client.go
@@ -444,6 +444,7 @@ func retryNetworkAndHTTPErrors(statusCodes ...int) RetryCondition {
 	}
 }
 
+// GetMetricsHeader constructs header value for metrics attribution
 func GetMetricsHeader(sdkVersion string) string {
 	goVersion := strings.TrimPrefix(runtime.Version(), "go")
 	return fmt.Sprintf("gl-go/%s fire-admin/%s", goVersion, sdkVersion)