Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets for new Auth features #356

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Conversation

samtstern
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

Based on:
firebase/snippets-node#94

Testing

Depends on #339 and #344

API Changes

N/A

@samtstern samtstern requested a review from rsgowman March 31, 2020 19:41
Copy link
Member

@rsgowman rsgowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to retarget this against dev instead of master. (The release process in go is effectively just merging the dev branch to master so if we merge direct to master, we bypass that.)

snippets/auth.go Outdated Show resolved Hide resolved
snippets/auth.go Show resolved Hide resolved
snippets/auth.go Show resolved Hide resolved
@samtstern
Copy link
Contributor Author

@rsgowman thanks for the comments! I feel dumb for making those syntax errors, but they also show the risk of writing snippets when you expect the CI to fail, I didn't even read the failure logs!

@samtstern samtstern changed the base branch from master to dev April 2, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants