-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snippets for new Auth features #356
base: dev
Are you sure you want to change the base?
Conversation
* chore: Added Actions-based release workflow * Set GOPATH * Fixed working directory for tests * Decrypting credentials into the testdata directory * Added preflight and post check scripts
…#335) According to the document https://developers.google.com/instance-id/reference/server, the endpoints should be: https://iid.googleapis.com/iid/v1:batchAdd https://iid.googleapis.com/iid/v1:batchRemove NOT: https://iid.googleapis.com/iid/v1/:batchAdd https://iid.googleapis.com/iid/v1/:batchRemove
Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to retarget this against dev
instead of master
. (The release process in go is effectively just merging the dev branch to master so if we merge direct to master, we bypass that.)
@rsgowman thanks for the comments! I feel dumb for making those syntax errors, but they also show the risk of writing snippets when you expect the CI to fail, I didn't even read the failure logs! |
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
Based on:
firebase/snippets-node#94
Testing
Depends on #339 and #344
API Changes
N/A