Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added topic subscription information retrieval to messaging client #362

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

m4ng0
Copy link

@m4ng0 m4ng0 commented Apr 16, 2020

This commit should provide the feature requested in FR #99.

@hiranya911
Copy link
Contributor

@chong-shao is this something the FCM team is interested in releasing?

Copy link
Contributor

@chong-shao chong-shao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is changing based on an old version of the go SDK. Could you make it to be based on a recent version?
Also looks like there a several Github Actions build errors.

@hiranya911
Copy link
Contributor

@chong-shao there's a product decision to be made here. Do we even want to expose this API in our SDKs? We ought to run this by a PM first.

@chong-shao
Copy link
Contributor

chong-shao commented May 8, 2020

@hiranya911 synced with our PM. The feedback is that we should not merge this into master branch unless the endpoint has been switched to the new one (which has not been set up yet).

Can we put this in a side branch? Or keeping the PR in open status until the new endpoints are ready? @andirayo

@hiranya911
Copy link
Contributor

@chong-shao I agree. We can keep the PR open for now.

We also possibly need an API proposal, and at least a semblance of a plan to have the same API exposed in other languages at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants