Added topic subscription information retrieval to messaging client #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Added Actions-based release workflow * Set GOPATH * Fixed working directory for tests * Decrypting credentials into the testdata directory * Added preflight and post check scripts
…firebase#335) According to the document https://developers.google.com/instance-id/reference/server, the endpoints should be: https://iid.googleapis.com/iid/v1:batchAdd https://iid.googleapis.com/iid/v1:batchRemove NOT: https://iid.googleapis.com/iid/v1/:batchAdd https://iid.googleapis.com/iid/v1/:batchRemove
Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com>
corresponding tests. This commit should provide the feature requested in FR firebase#99.
|
@chong-shao is this something the FCM team is interested in releasing? |
andirayo
reviewed
Apr 21, 2020
chong-shao
requested changes
May 7, 2020
|
@chong-shao there's a product decision to be made here. Do we even want to expose this API in our SDKs? We ought to run this by a PM first. |
|
@hiranya911 synced with our PM. The feedback is that we should not merge this into master branch unless the endpoint has been switched to the new one (which has not been set up yet). Can we put this in a side branch? Or keeping the PR in open status until the new endpoints are ready? @andirayo |
|
@chong-shao I agree. We can keep the PR open for now. We also possibly need an API proposal, and at least a semblance of a plan to have the same API exposed in other languages at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should provide the feature requested in FR #99.