Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Supported Go versions to 1.20, 1.21, 1.22 #607

Merged
merged 5 commits into from
Mar 20, 2024
Merged

chore: Bump Supported Go versions to 1.20, 1.21, 1.22 #607

merged 5 commits into from
Mar 20, 2024

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Mar 19, 2024 •
edited
Loading

  • Bump Go versions to 1.20, 1.21, 1.22

@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Mar 19, 2024
@lahirumaramba lahirumaramba removed the release:stage Stage a release candidate label Mar 19, 2024
@lahirumaramba lahirumaramba changed the title chore: Bump Go versions in CIs chore: Bump Supported Go versions to 1.20, 1.21, 1.22 Mar 19, 2024
jonathanedey
jonathanedey reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update go.mod and go.sum as well?

@lahirumaramba
Copy link
Member Author

Do we need to update go.mod and go.sum as well?

Not for this PR. We will do a follow up PR to upgrade dependencies, which will update go.sum and go.mod for dependencies. I updated the supported version in go.mod. Thanks!

jonathanedey
jonathanedey approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! LGTM

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Mar 20, 2024
@lahirumaramba lahirumaramba merged commit 9e96b5a into dev Mar 20, 2024
8 checks passed
@lahirumaramba lahirumaramba deleted the lm-up-platform branch March 20, 2024 16:25
@lahirumaramba lahirumaramba mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanedey jonathanedey jonathanedey approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahirumaramba @jonathanedey