feat(app): allow configuring firestore instance id #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋🏻 hey there
I'm trying to use the firebase sdk for my app but I'm not using the default
(default)
firestore db instance, which seems to be the only supported option by this sdkthis mr introduces a new option,
firestoreID
configurable like the others, via json or via explicit values in theConfig
struct, and passes this value to theNewClientWithDatabase
firestore constructorif no value is supplied, the default db is still targeted, so this shouldn't incur any breaking change to existing users, moreover, there's no hardcoded values, I'm using the public variable exposed by the firestore package
I've also updated the tests to not only verify that the constructor succeeds, but also that the correct database is being used when e.g. building document refs