Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): allow configuring firestore instance id #631

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

aexvir
Copy link

@aexvir aexvir commented Jun 11, 2024

👋🏻 hey there
I'm trying to use the firebase sdk for my app but I'm not using the default (default) firestore db instance, which seems to be the only supported option by this sdk

this mr introduces a new option, firestoreID configurable like the others, via json or via explicit values in the Config struct, and passes this value to the NewClientWithDatabase firestore constructor

if no value is supplied, the default db is still targeted, so this shouldn't incur any breaking change to existing users, moreover, there's no hardcoded values, I'm using the public variable exposed by the firestore package

I've also updated the tests to not only verify that the constructor succeeds, but also that the correct database is being used when e.g. building document refs

Copy link

google-cla bot commented Jun 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aexvir aexvir force-pushed the aexvir/firestore-db-override branch 2 times, most recently from 64b25f7 to 984a7b3 Compare June 11, 2024 20:35
@aexvir
Copy link
Author

aexvir commented Jul 5, 2024

@lahirumaramba sorry for the ping, do you think someone could review this anytime soon?

@aexvir aexvir force-pushed the aexvir/firestore-db-override branch from 9d1e45d to c8857c6 Compare July 5, 2024 19:21
@lahirumaramba lahirumaramba self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants