Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort snapshot listeners on terminate #6136

Open
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

tom-andersen
Copy link
Contributor

No description provided.

…actor' into tomandersen/componentProviderRefactor
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Unit Test Results

   186 files   -    782     186 suites   - 782   4m 39s ⏱️ - 30m 31s
1 234 tests  - 4 089  1 218 ✔️  - 4 084  16 💤  -   5  0 ±0 
2 492 runs   - 8 239  2 460 ✔️  - 8 229  32 💤  - 10  0 ±0 

Results for commit 36daf54. ± Comparison against base commit d5d133b.

♻️ This comment has been updated with latest results.

@tom-andersen tom-andersen assigned tom-andersen and unassigned wu-hui Jul 30, 2024
Base automatically changed from tomandersen/firestoreClientProvider to main August 12, 2024 16:34
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2024

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentiled5d133b798deebDiffSignificant (?)
    p10311 ±19 μs306 ±9.5 μs-5.85 μs (-1.9%)NO
    p25328 ±32 μs317 ±9.8 μs-11.0 μs (-3.4%)NO
    p50354 ±54 μs334 ±16 μs-19.6 μs (-5.6%)NO
    p75437 ±99.7 μs384 ±57 μs-52.7 μs (-12.1%)NO
    p90554 ±182 μs469 ±89 μs-85.2 μs (-15.4%)NO

    20 test runs in comparison
    CommitTest Runs
    d5d133b
    • 2024-09-13_04:34:09.948696_JVzI
    • 2024-09-13_04:34:09.948750_TGWD
    • 2024-09-13_04:34:09.948762_uSDa
    • 2024-09-13_04:34:09.948769_SGcR
    • 2024-09-13_04:34:09.948776_zbNu
    • 2024-09-13_04:34:09.948784_jxNI
    • 2024-09-13_04:34:09.948791_IERQ
    • 2024-09-13_04:34:09.948798_sIoT
    • 2024-09-13_04:34:09.948804_keyP
    • 2024-09-13_04:34:09.948816_rMFI
    798deeb
    • 2024-09-13_14:43:38.244377_JpKm
    • 2024-09-13_14:43:38.244417_jtPb
    • 2024-09-13_14:43:38.244429_ZQKg
    • 2024-09-13_14:43:38.244436_gWoI
    • 2024-09-13_14:43:38.244447_Hjqy
    • 2024-09-13_14:43:38.244457_iZiV
    • 2024-09-13_14:43:38.244464_LxMt
    • 2024-09-13_14:43:38.244471_dmgG
    • 2024-09-13_14:43:38.244478_MMdI
    • 2024-09-13_14:43:38.244486_FEWJ
    redfin-30
    Percentiled5d133b798deebDiffSignificant (?)
    p10597 ±25 μs631 ±50 μs+33.7 μs (+5.6%)NO
    p25616 ±29 μs650 ±51 μs+34.2 μs (+5.6%)NO
    p50646 ±41 μs678 ±44 μs+31.6 μs (+4.9%)NO
    p75679 ±50 μs714 ±40 μs+34.6 μs (+5.1%)NO
    p90729 ±76 μs757 ±39 μs+28.1 μs (+3.8%)NO

    20 test runs in comparison
    CommitTest Runs
    d5d133b
    • 2024-09-13_04:34:09.948696_JVzI
    • 2024-09-13_04:34:09.948750_TGWD
    • 2024-09-13_04:34:09.948762_uSDa
    • 2024-09-13_04:34:09.948769_SGcR
    • 2024-09-13_04:34:09.948776_zbNu
    • 2024-09-13_04:34:09.948784_jxNI
    • 2024-09-13_04:34:09.948791_IERQ
    • 2024-09-13_04:34:09.948798_sIoT
    • 2024-09-13_04:34:09.948804_keyP
    • 2024-09-13_04:34:09.948816_rMFI
    798deeb
    • 2024-09-13_14:43:38.244377_JpKm
    • 2024-09-13_14:43:38.244417_jtPb
    • 2024-09-13_14:43:38.244429_ZQKg
    • 2024-09-13_14:43:38.244436_gWoI
    • 2024-09-13_14:43:38.244447_Hjqy
    • 2024-09-13_14:43:38.244457_iZiV
    • 2024-09-13_14:43:38.244464_LxMt
    • 2024-09-13_14:43:38.244471_dmgG
    • 2024-09-13_14:43:38.244478_MMdI
    • 2024-09-13_14:43:38.244486_FEWJ
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentiled5d133b798deebDiffSignificant (?)
    p10200 ±4 ms205 ±5 ms+5.71 ms (+2.9%)NO
    p25206 ±4 ms212 ±5 ms+5.90 ms (+2.9%)NO
    p50212 ±4 ms219 ±4 ms+7.90 ms (+3.7%)NO
    p75220 ±5 ms228 ±4 ms+7.90 ms (+3.6%)NO
    p90228 ±4 ms240 ±8 ms+12.5 ms (+5.5%)NO

    20 test runs in comparison
    CommitTest Runs
    d5d133b
    • 2024-09-13_04:34:09.948696_JVzI
    • 2024-09-13_04:34:09.948750_TGWD
    • 2024-09-13_04:34:09.948762_uSDa
    • 2024-09-13_04:34:09.948769_SGcR
    • 2024-09-13_04:34:09.948776_zbNu
    • 2024-09-13_04:34:09.948784_jxNI
    • 2024-09-13_04:34:09.948791_IERQ
    • 2024-09-13_04:34:09.948798_sIoT
    • 2024-09-13_04:34:09.948804_keyP
    • 2024-09-13_04:34:09.948816_rMFI
    798deeb
    • 2024-09-13_14:43:38.244377_JpKm
    • 2024-09-13_14:43:38.244417_jtPb
    • 2024-09-13_14:43:38.244429_ZQKg
    • 2024-09-13_14:43:38.244436_gWoI
    • 2024-09-13_14:43:38.244447_Hjqy
    • 2024-09-13_14:43:38.244457_iZiV
    • 2024-09-13_14:43:38.244464_LxMt
    • 2024-09-13_14:43:38.244471_dmgG
    • 2024-09-13_14:43:38.244478_MMdI
    • 2024-09-13_14:43:38.244486_FEWJ
    redfin-30
    Percentiled5d133b798deebDiffSignificant (?)
    p10241 ±3 ms273 ±15 ms+32.5 ms (+13.5%)NO
    p25247 ±3 ms280 ±14 ms+32.9 ms (+13.3%)NO
    p50253 ±3 ms288 ±15 ms+35.6 ms (+14.1%)NO
    p75261 ±4 ms299 ±16 ms+38.1 ms (+14.6%)NO
    p90269 ±4 ms319 ±17 ms+49.9 ms (+18.5%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    d5d133b
    • 2024-09-13_04:34:09.948696_JVzI
    • 2024-09-13_04:34:09.948750_TGWD
    • 2024-09-13_04:34:09.948762_uSDa
    • 2024-09-13_04:34:09.948769_SGcR
    • 2024-09-13_04:34:09.948776_zbNu
    • 2024-09-13_04:34:09.948784_jxNI
    • 2024-09-13_04:34:09.948791_IERQ
    • 2024-09-13_04:34:09.948798_sIoT
    • 2024-09-13_04:34:09.948804_keyP
    • 2024-09-13_04:34:09.948816_rMFI
    798deeb
    • 2024-09-13_14:43:38.244377_JpKm
    • 2024-09-13_14:43:38.244417_jtPb
    • 2024-09-13_14:43:38.244429_ZQKg
    • 2024-09-13_14:43:38.244436_gWoI
    • 2024-09-13_14:43:38.244447_Hjqy
    • 2024-09-13_14:43:38.244457_iZiV
    • 2024-09-13_14:43:38.244464_LxMt
    • 2024-09-13_14:43:38.244471_dmgG
    • 2024-09-13_14:43:38.244478_MMdI
    • 2024-09-13_14:43:38.244486_FEWJ

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IarFSsGqfX/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants