Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 34 WorkManager Scheduler #6221
base: main
Are you sure you want to change the base?
Android 34 WorkManager Scheduler #6221
Changes from 6 commits
1f16596
dab5584
1cb0ed4
ca0644a
7c99278
3a4cb1c
15c5c90
bd1ad49
0564a10
1a47878
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getWorkInfosByTag
returns a list, but it should always be exactly 1, right? If that's the case, we need to verify that condition, as if it's not true something else has gone wrong, instead of looping through it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, maybe it keeps finished jobs for some period of time? It wouldn't be a condition we verify though, scheduling can be called with
force = true
beforehand and schedule multiple before calling withforce = false
, I think.