Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade javalite #6277

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import com.google.firebase.testing.LinkedListProto
import com.google.firebase.testing.SimpleProto
import com.google.firebase.testing.Types
import com.google.protobuf.Descriptors.FileDescriptor
import com.google.protobuf.GeneratedMessageV3
import com.google.protobuf.GeneratedMessage
import com.google.protobuf.Timestamp
import org.junit.Test
import org.junit.runner.RunWith
Expand Down Expand Up @@ -153,7 +153,7 @@ class ParsingTests {

private fun parse(
vararg files: FileDescriptor,
include: List<GeneratedMessageV3> = listOf()
include: List<GeneratedMessage> = listOf()
): List<UserDefined> {
return DefaultParser(
CodeGenConfig.newBuilder()
Expand Down
2 changes: 1 addition & 1 deletion encoders/protoc-gen-firebase-encoders/tests/tests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dependencies {

testImplementation project(":encoders:firebase-encoders")
testImplementation project(":encoders:firebase-encoders-proto")
testImplementation "com.google.protobuf:protobuf-java:3.21.9"
testImplementation libs.protobuf.java
testImplementation "com.google.truth:truth:1.0.1"
testImplementation 'junit:junit:4.13.1'
}
2 changes: 1 addition & 1 deletion firebase-crashlytics/firebase-crashlytics.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ dependencies {
androidTestImplementation(libs.androidx.test.runner)
androidTestImplementation(libs.androidx.test.junit)
androidTestImplementation("com.google.firebase:firebase-encoders-json:18.0.1")
androidTestImplementation("com.google.protobuf:protobuf-java:3.21.11")
androidTestImplementation(libs.protobuf.java)
androidTestImplementation(libs.truth)
androidTestImplementation("com.linkedin.dexmaker:dexmaker:2.28.3")
androidTestImplementation(libs.mockito.dexmaker)
Expand Down
4 changes: 2 additions & 2 deletions firebase-perf/firebase-perf.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ dependencies {
implementation 'com.google.dagger:dagger:2.27'
api 'com.google.firebase:firebase-annotations:16.2.0'
api 'com.google.firebase:firebase-installations-interop:17.1.0'
api 'com.google.firebase:protolite-well-known-types:18.0.0'
api project(':protolite-well-known-types')
implementation 'com.squareup.okhttp3:okhttp:3.12.1'
api("com.google.firebase:firebase-common:21.0.0")
api("com.google.firebase:firebase-common-ktx:21.0.0")
Expand All @@ -130,7 +130,7 @@ dependencies {
exclude group: 'com.google.firebase', module: 'firebase-common'
exclude group: 'com.google.firebase', module: 'firebase-components'
}
testCompileOnly "com.google.protobuf:protobuf-java:3.21.9"
testCompileOnly libs.protobuf.java
testImplementation "androidx.test:core:$androidxTestCoreVersion"
testImplementation "com.google.truth:truth:$googleTruthVersion"
testImplementation "org.robolectric:robolectric:$robolectricVersion"
Expand Down
2 changes: 1 addition & 1 deletion firebase-perf/ktx/ktx.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ dependencies {
testImplementation 'org.mockito:mockito-core:2.25.0'
testImplementation "org.robolectric:robolectric:$robolectricVersion"

testCompileOnly "com.google.protobuf:protobuf-java:3.21.9"
testCompileOnly libs.protobuf.java
}
5 changes: 3 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ autovalue = "1.10.1"
coroutines = "1.6.4"
dagger = "2.43.2"
grpc = "1.62.2"
javalite = "3.21.11"
javalite = "4.28.1"
kotlin = "1.8.22"
protobuf-java = "3.21.9"
serialization-plugin = "1.8.22"
protoc = "3.21.11"
protoc = "4.28.1"
truth = "1.4.2"
robolectric = "4.12"
protobufjavautil = "3.21.11"
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion protolite-well-known-types/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# IMPORTANT (b/285892320) Keep version and latestReleasedVersion in sync
# unless you are releasing a new version of the library to prevent issues
# with transitive dependencies.
version=18.0.0
version=18.0.1
latestReleasedVersion=18.0.0
4 changes: 2 additions & 2 deletions protolite-well-known-types/protolite-well-known-types.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ protobuf {
generateProtoTasks {
all().each { task ->

task.addIncludeDir(files('fix-javalite/proto'))
// task.addIncludeDir(files('fix-javalite/proto'))

task.builtins {
java {
Expand Down Expand Up @@ -64,7 +64,7 @@ android {


dependencies {
protobuf("com.google.api.grpc:proto-google-common-protos:1.18.0"){
protobuf("com.google.api.grpc:proto-google-common-protos:2.17.0"){
exclude group: "com.google.protobuf", module: "protobuf-java"
}

Expand Down
Loading
Loading