-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firebase-dataconnect merge into main branch #6290
Conversation
…d added unit tests
…eapis.com (was dataconnect.googleapis.com)
… tests should never be mucking around with the default app
…y `firebase dataconnect init`
…he cli directly does not appear to pick up the value from .firebaserc
…e-auth-token header
…when it needs to be changed
…edataconnect.googleapis.com" (was "dataconnect.googleapis.com")
…ect sdk prior to public announcements at i/o (#563)
…and libs.kotlinx.serialization.core dependencies to implementation, instead of api
…is joining the main release process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Build files look fine to me. Still have pending work that needs @rachelsaunders input here, but otherwise I defer to @rlazo for final approval.
Also, worth looking at the smoke test failure. Those don't usually flake.
@rlazo I may need you to merge this PR for me because it won't let me because the cla presubmit is broken with such a large PR. |
The most recent failure of the smoke test (at the time of writing) was due to this error:
A re-run fixed it. Also, I've opened 2 PRs to fix flaky tests that I came across: #6290 and #6291. I'll continue to monitor the flaky failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.
If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.
Thx!
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
…onnect.kt to CHANGELOG.md
Done. Please take a look at https://github.com/firebase/firebase-android-sdk/blob/dataconnect/firebase-dataconnect/CHANGELOG.md. Also, do you know what values to specify for |
Beautiful :-D
This would be something that @daymxn or @rlazo can help you with. |
Includes contributions by @cherylEnkidu --------- Co-authored-by: cherylEnkidu <96084918+cherylEnkidu@users.noreply.github.com> Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Includes contributions by @cherylEnkidu --------- Co-authored-by: cherylEnkidu <96084918+cherylEnkidu@users.noreply.github.com> Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Includes contributions by @cherylEnkidu