-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: sort document reference by long type id #6594
Conversation
Release note changesNo release note changes were detected. If you made changes that should be |
Vertex AI Mock Responses Check
|
Coverage Report 1Affected Products
Test Logs |
Test Results 186 files - 825 186 suites - 825 4m 26s ⏱️ - 29m 52s Results for commit fc2b0b5. ± Comparison against base commit 50eacb7. This pull request removes 4640 tests.
♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make the following improvement to the test utils? (this was not added or modified by this PR, but it'd make sense to improve it here).
Document ID supports strings and well as long integers in the format of "id" . When sorting documents by document ID, it should be sorted in the following order: