Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sort document reference by long type id #6594

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 11, 2024

Document ID supports strings and well as long integers in the format of "id" . When sorting documents by document ID, it should be sorted in the following order:

  1. Long (numeric order)
  2. String (lexicographic order)

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 11, 2024

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.73% (50eacb7) to 45.72% (dd0d1a1) by -0.00%.

    FilenameBase (50eacb7)Merge (dd0d1a1)Diff
    BasePath.java86.54%82.54%-4.00%
    LruGarbageCollector.java97.27%93.64%-3.64%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Iv2RPwqjpV.html

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Test Results

  186 files   -   825    186 suites   - 825   4m 26s ⏱️ - 29m 52s
1 234 tests  - 4 640  1 218 ✅  - 4 633  16 💤  -  6  0 ❌  - 1 
2 492 runs   - 8 883  2 460 ✅  - 8 871  32 💤  - 11  0 ❌  - 1 

Results for commit fc2b0b5. ± Comparison against base commit 50eacb7.

This pull request removes 4640 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 11, 2024

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (50eacb7)Merge (dd0d1a1)Diff
    aar1.45 MB1.45 MB+338 B (+0.0%)
    apk (release)11.4 MB11.4 MB+328 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IeSPHCCmjs.html

Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the following improvement to the test utils? (this was not added or modified by this PR, but it'd make sense to improve it here).

@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Dec 11, 2024
@milaGGL milaGGL merged commit 3dd8ddf into main Dec 17, 2024
32 checks passed
@milaGGL milaGGL deleted the mila/fix-sdk-sort-document-reference-bug branch December 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants