Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: comparing double with long #6604

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 17, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.3

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.74% (3dd8ddf) to 45.72% (980c5e5) by -0.01%.

    FilenameBase (3dd8ddf)Merge (980c5e5)Diff
    LruGarbageCollector.java97.27%93.64%-3.64%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jhAtxjF5Xx.html

Copy link
Contributor

Test Results

  186 files  ±0    186 suites  ±0   4m 27s ⏱️ -54s
1 234 tests ±0  1 218 ✅ ±0  16 💤 ±0  0 ❌ ±0 
2 492 runs  ±0  2 460 ✅ ±0  32 💤 ±0  0 ❌ ±0 

Results for commit fa56f60. ± Comparison against base commit 3dd8ddf.

@google-oss-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants