Add app unit tests to app internal integration test #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| for (int i = 0; i < args_vector.size(); ++i) { | ||
| const char* arg = args_vector[i].c_str(); | ||
| char* arg_copy = new char[std::strlen(arg) + 1]; | ||
| std::strcpy(arg_copy, arg); |
There was a problem hiding this comment.
Almost always, snprintf is better than strcpy
|
|
||
| // Blocking HTTP request helper function, for testing only. | ||
| static bool SendHttpPostRequest( | ||
| const char* url, const std::map<std::string, std::string>& headers, |
There was a problem hiding this comment.
Add #include <map> for map<>
| static bool Base64Encode(const std::string& input, std::string* output); | ||
| // Decode a base64 string to binary. Returns true if the decoding succeeded, | ||
| // false if it failed. | ||
| static bool Base64Decode(const std::string& input, std::string* output); |
There was a problem hiding this comment.
Add #include <string> for string
| @@ -82,12 +81,14 @@ using testing::Not; | |||
|
|
|||
| namespace firebase { | |||
|
|
|||
| extern std::string g_test_srcdir; | |||
| std::string g_test_srcdir; | |||
There was a problem hiding this comment.
Static/global string variables are not permitted.
| EXPECT_EQ(encoded_firebase, encoded_openssh) | ||
| << "Encoding mismatch on source buffer: " << orig; | ||
|
|
||
| std::string decoded_firebase_to_openssh; | ||
| std::string decoded_openssh_to_firebase; | ||
| ASSERT_TRUE(Base64Decode(encoded_openssh, &decoded_openssh_to_firebase)); | ||
| ASSERT_TRUE(OpenSSHDecode(encoded_firebase, &decoded_firebase_to_openssh)); | ||
| ASSERT_TRUE(OpenSSHDecode(&encoded_firebase[0], encoded_firebase.length(), | ||
| &decoded_firebase_to_openssh)); |
There was a problem hiding this comment.
Tab found; better to use spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.