-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a couple of workarounds for Swift on Windows #1414
Open
compnerd
wants to merge
7
commits into
firebase:main
Choose a base branch
from
compnerd:swift
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Commits on Aug 7, 2023
-
Add a couple of workarounds for Swift on Windows
The C++ Interop efforts in Swift currently have some limitations. In particular, it cannot support trivial types with non-trivial destructors. As a workaround, provide a copy constructor which can be used by the Swift interop while using the regular semantics for all other cases. A second issue arises in the handling of futures. Unfortunately, it is not currently possible to pass an indirect block parameter which prevents the construction of a callback. Workaround this by providing an inline shim to use a direct parameter (i.e. indirect value through a pointer) which then allows a callback to be formed. Both of these items are being tracked upstream but seem to be potentially sufficient to enable the use of Swift for using the C++ SDK for desktop scenarios.
Configuration menu - View commit details
-
Copy full SHA for c912e46 - Browse repository at this point
Copy the full SHA c912e46View commit details
Commits on Oct 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ef4a1c5 - Browse repository at this point
Copy the full SHA ef4a1c5View commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 09a1620 - Browse repository at this point
Copy the full SHA 09a1620View commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf26dae - Browse repository at this point
Copy the full SHA cf26daeView commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 745552e - Browse repository at this point
Copy the full SHA 745552eView commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bedd01 - Browse repository at this point
Copy the full SHA 4bedd01View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fb19ce4 - Browse repository at this point
Copy the full SHA fb19ce4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.