Expose generic types of @google-cloud/firestore #1229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the already existing generic types of
@google-cloud/firestore
forDocumentSnapshot
andQueryDocumentSnapshot
.I've also added the default to not introduce any breaking change and keep the typing optional. In regard to less readable documentation and a cleaner implementation I've also added the default type
DocumentData
as an exposed type.Currently you cannot even overwrite
QueryDocumentSnapshot
with the generic type of@google-cloud/firestore
since the handler will not accept the same as it uses an internal reflected type ofQueryDocumentSnapshot
. Hence an explicit type cast needs to be placed during unwrapping. E.g.This change will enable the following implementation:
If you need me to make any changes please let me know.