Allow emitting eventarc channels as params #1313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
approved these changes
Nov 16, 2022
taeold
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
As far as interesting PRs go, this ain't it, chief.Though I have to say it's a little surprising that we define channel as a possible field on the base EventOptions class, despite it only being meaningful to have in one type of Event trigger option? That seems like not how classes should work, unless I'm really missing something about Typescript?
Yeah maybe custom event should've been it's own trigger type, like scheduledTrigger or taskQueueTrigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as interesting PRs go, this ain't it, chief.
Though I have to say it's a little surprising that we define channel as a possible field on the base EventOptions class, despite it only being meaningful to have in one type of Event trigger option? That seems like not how classes should work, unless I'm really missing something about Typescript?