-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes encoding of circular referenced object / complex object #1525
Open
DavidWeiss2
wants to merge
7
commits into
firebase:master
Choose a base branch
from
DavidWeiss2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidWeiss2
changed the title
Add encoding tests And implementation for circular references
Fixes #1527 - Add encoding tests And implementation for circular references
Feb 20, 2024
DavidWeiss2
changed the title
Fixes #1527 - Add encoding tests And implementation for circular references
Fixes encoding of circular referenced object / complex object
Feb 20, 2024
…and to throw on this case
Refactored to reflect team decision on throwing in the case of self ref. |
elektronik2k5
approved these changes
Sep 12, 2024
@inlined Can we get update on this PR status? |
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances Firebase functions v2 by fixing an issue related to encoding objects with self-references, which previously led to "Maximum call stack size exceeded" errors. The change is to throw a clear error on what is the error (not JSON serializable, with object ref in console).
For a practical demonstration, consider a class instance with self-referencing properties. The updated encoding function now throws
Data cannot be encoded in JSON: [object: object]
in such cases, preventing stack overflow errors and ensuring the encoded output reflects the object's structure accurately, without infinite recursion. This improvement is verified through comprehensive test case included in the PR.It fixes #1527
Code sample
See test cases.
The code before the change will give "Maximum call stack size exceeded" even on the basic case: