Skip to content

Commit

Permalink
[Vertex AI] Fix testCountTokens_jsonSchema integration test (#14049)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewheard authored Nov 7, 2024
1 parent 869c7f5 commit 32a6788
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions FirebaseVertexAI/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Unreleased
- [changed] The token counts from `GenerativeModel.countTokens(...)` now include
tokens from the schema for JSON output and function calling; reported token
counts will now be higher if using these features.

# 11.5.0
- [fixed] Fixed an issue where `VertexAI.vertexAI(app: app1)` and
`VertexAI.vertexAI(app: app2)` would return the same instance if their
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,8 @@ final class IntegrationTests: XCTestCase {

let response = try await model.countTokens(prompt)

XCTAssertEqual(response.totalTokens, 34)
XCTAssertEqual(response.totalBillableCharacters, 59)
XCTAssertEqual(response.totalTokens, 58)
XCTAssertEqual(response.totalBillableCharacters, 160)
}

func testCountTokens_appCheckNotConfigured_shouldFail() async throws {
Expand Down

0 comments on commit 32a6788

Please sign in to comment.