Make generativeModel an instance method of VertexAI
#12599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Mar 21, 2024
| @@ -20,70 +20,81 @@ import Foundation | |||
| @_implementationOnly import FirebaseCoreExtension | |||
|
|
|||
| @available(iOS 15.0, macOS 11.0, macCatalyst 15.0, *) | |||
| @objc(FIRVertexAI) | |||
There was a problem hiding this comment.
Does it need to be objc to be initialized by the Component system?
There was a problem hiding this comment.
I think so. I was seeing Cannot convert value of type '(any VertexAIProvider).Type' to expected argument type 'Protocol' when I dropped the @objcs.
|
@paulb777 Already set to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog