Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Add double quotes around vars in rotate_secrets.sh #13181

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[Infra] Add double quotes around vars in rotate_secrets.sh #13181

merged 1 commit into from
Jun 25, 2024

Conversation

andrewheard
Copy link
Contributor

nits: Add double quotes to prevent globbing and word splitting in rotate_secrets.sh (SC2086).

#no-changelog

@andrewheard andrewheard requested a review from ncooke3 June 25, 2024 16:23
ncooke3
ncooke3 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@andrewheard andrewheard merged commit 45529b2 into main Jun 25, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/secrets-rotation branch June 25, 2024 16:32
@firebase firebase locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @ncooke3