Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove dated TODOs #13190

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[NFC] Remove dated TODOs #13190

merged 1 commit into from
Jun 26, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 26, 2024

Fix #13051

@ncooke3 ncooke3 enabled auto-merge (squash) June 26, 2024 17:49
@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Jun 26, 2024
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 closed this Jun 26, 2024
auto-merge was automatically disabled June 26, 2024 18:00

Pull request was closed

@ncooke3 ncooke3 reopened this Jun 26, 2024
@ncooke3 ncooke3 requested a review from paulb777 June 26, 2024 18:00
@ncooke3 ncooke3 merged commit 26fcf04 into main Jun 26, 2024
94 of 98 checks passed
@ncooke3 ncooke3 deleted the nc/remove-todos branch June 26, 2024 18:01
@firebase firebase locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Firebase 11] Audit FIAM API tests for potential improvement opportunities
3 participants
@ncooke3 @google-oss-bot @paulb777