-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VQ exploration #13448
Draft
MarkDuckworth
wants to merge
30
commits into
main
Choose a base branch
from
markduckworth/vq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
VQ exploration #13448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duckworth/vector-type
…ase-ios-sdk into markduckworth/vector-type
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Generated by 🚫 Danger |
Apple API Diff ReportCommit: a7b8ef7 [BUILD ERROR] FirebaseFirestoreInternal[BUILD ERROR] FirebaseFirestore |
…duckworth/vector-type
…ase-ios-sdk into markduckworth/vector-type
MarkDuckworth
added
public-api-change
and removed
api: core
api: database
api: auth
api: messaging
api: storage
api: analytics
api: dynamiclinks
api: performance
api: remoteconfig
api: crashlytics
api: functions
api: abtesting
api: inappmessaging
Firebase In App Messaging
api: installations
public-api-change
api: appdistribution
release-tooling
api: appcheck
labels
Aug 8, 2024
peterfriese
reviewed
Aug 12, 2024
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
NS_SWIFT_NAME(VectorQuery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be marked as NS_SWIFT_SENDABLE
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.