Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DocumentID sendable #13537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make DocumentID sendable #13537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Firestore/Swift/Source/Codable/DocumentID.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ protocol DocumentIDProtocol {
/// its value is ignored. This allows you to read a document from one path and
/// write it into another without adjusting the value here.
@propertyWrapper
public struct DocumentID<Value: DocumentIDWrappable & Codable>:
StructureCodingUncodedUnkeyed {
public struct DocumentID<Value: DocumentIDWrappable & Codable & Sendable>:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it can be Sendable because the public wrappedValue API with a setter makes it mutable.

StructureCodingUncodedUnkeyed, Sendable {
private var value: Value? = nil

public init(wrappedValue value: Value?) {
Expand Down
Loading