Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Performance Unit Tests requiring Unswizzling #13791

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Performance Unit Tests requiring Unswizzling #13791

wants to merge 4 commits into from

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Oct 3, 2024 •
edited
Loading

There are tests that supposedly require unswizzling, but when I remove the assertion, they all pass. There doesn't seem to be any issues removing all unswizzling from the unit tests.

#no-changelog

@samedson
Copy link
Contributor Author

samedson commented Oct 3, 2024

Screenshot 2024-10-03 at 11 26 10 AM

Just one test failure

@samedson
Copy link
Contributor Author

samedson commented Oct 3, 2024

#11903

visumickey
visumickey reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally worried about this change since we are removing the unswizzle code. Let me review this again to make sure we are safe here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visumickey visumickey visumickey left review comments

@themiswang themiswang themiswang approved these changes

Assignees
No one assigned
Labels
api: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samedson @visumickey @themiswang @google-oss-bot